Files
DSP_Mods/docs/design-cleanup
soarqin ba2648a3e3 refactor: remove single-owner helpers and redundant plumbing
Return feature-only helpers to their owners, remove inactive scaffolding and duplicate state, and reuse existing calculation and UI work without changing public contracts or gameplay.

Record repository-wide coverage, justified retentions, independent reviews and validation, including baseline dashboard fixture failures.

Assisted-by: Cindy (https://cindy.app)
2026-11-09 02:36:52 +08:00
..

Repository design cleanup

Baseline: latest origin/master at the start and final synchronization check on 2026-11-04, 64a23e9772e7878f216cc2e281da2bc3f87d3140. Branch: cleanup-single-owner-abstractions. Work is isolated in the registered sharp-lamarr worktree; PR #106 and other worktrees are untouched.

Outcome

Review covered all 356 baseline tracked paths: 235 maintained first-party source/project/build paths, five retired source/project paths inspected read-only, three generated frontend outputs, and 113 supporting docs/config/assets. The file inventory records every disposition. This is a design audit of the whole maintained repository, using module inventories, connected flows, symbol/string searches and actual metadata contracts; it is not an exhaustive gameplay/correctness certification.

Delete three owner-only helper files (TechKeyCombo, TechLog, FastDronesRemover), return their useful logic to its owner, and eliminate redundant private wrappers, state, parameters, allocations, sorting, no-op lifecycle dispatch and inactive experiments. Unify PoolOpt's duplicate managed bookkeeping. Preserve meaningful algorithms, independently checked boundaries, public compatibility facades, serializers and native patch signatures. No new runtime source file, dependency, framework, version or data format is introduced.

The only diagnostic normalization is PoolOpt's existing DEBUG reset text also being emitted for the all-empty trash fallback. Pool state and all player-visible behavior remain the same. No active native Harmony target/IL body changes; the moved FastDrones prefix keeps its exact external target and false result.

Audit decisions

Independent review

Three cross-reviews cover every implementation group, performed by workers who did not author that group:

The root executor additionally reviewed the final diff and the acceptance-script simplification. No cleanup was replaced with a new single-purpose helper file or general framework.

Verification

Validation and limitations records passing builds/checks and the seven baseline dashboard fixture failures. The persistent delivery directory contains full diff, raw verification logs, temporary equivalence-check source and a PR receipt; game DLLs and decompiled game source are not included.