Files
DSP_Mods/docs/design-cleanup/remaining-mods-tools.md
T
soarqin ba2648a3e3 refactor: remove single-owner helpers and redundant plumbing
Return feature-only helpers to their owners, remove inactive scaffolding and duplicate state, and reuse existing calculation and UI work without changing public contracts or gameplay.

Record repository-wide coverage, justified retentions, independent reviews and validation, including baseline dashboard fixture failures.

Assisted-by: Cindy (https://cindy.app)
2026-11-09 02:36:52 +08:00

7.7 KiB

Other mods, transport, frontend and repository tools

Baseline: 64a23e9772e7878f216cc2e281da2bc3f87d3140, 2026-11-04. See coverage for every tracked path. This partition contains 61 maintained source/project/build paths; test-tool details are in check-tools.

Applied cleanup

Owner Evidence and final change Preserved contract
MechaDronesTweaks FastDronesRemover was an internal 25-line type used only by the plugin constructor and its dependency attribute. Move the version gate, suppression patch and constant into that plugin; delete the file and helper type. Remove the identical second EnergyMultiplier binding. Same soft-dependency GUID, version 0.0.5 gate, external Start target, false prefix result, log/error boundary, config key/default/range and patch timing. Private prefix is resolved with nameof/AccessTools.
Dustbin Three private resource-to-texture-to-sprite wrappers existed only to load one owned embedded icon. Combine them into LoadDustbinSprite, remove unused optional assembly/path generality. Same Dustbin.assets.icon.signal-410.png, Texture2D size/load, sprite rectangle/pivot, stream disposal and preload callback. The project resource include and assembly name resolve to that exact name.
PoolOpt ID and trash-sentinel overloads duplicated the same tail scan/reset/recycle algorithm. Use one local occupancy predicate taking the slot index; remove unused ref capacity arguments from all 33 calls and replace the no-argument delegate with Action. Same occupied-slot criteria, in T passing, all native reset callbacks, capacities, cursor/recycle results and game-load hook. The fallback for an empty trash pool now emits the same existing DEBUG reset message as other pools; this diagnostic normalization has no state or UI effect. No per-slot closure allocation. Exhaustive before/after state checks are recorded in validation.
HideTips Remove the entirely commented HideMenuDemo experiment, its commented config wiring and the never-assigned private _patch field/no-op destroy callback. Existing active Harmony registration and all suppression/progression behavior remain unchanged. No disabled option becomes active.
OverclockEverything Remove entirely commented GalacticScale belt/collider experiments and their dead helper. All live patches, prefab updates, serialized configuration order and multiplier defaults remain unchanged.

No runtime source file was added. No version, changelog, feature README, package manifest, user data or public API was changed. These changes do not introduce new user-visible features or fixes requiring release notes.

Reviewed and retained

Scope Design decision and evidence
Dustbin / DustbinPreloader Storage and tank patches each own different native component and UI paths; shared checkbox has two actual users. Packet classes have serializer constructors and processor discovery attributes; empty save callback implements DSPModSave. Preloader is a separate process-phase boundary consumed through generated compile references. Keep old negative-ban import migration because it reads legacy user data. Similar save loops carry different byte tags/reference-vs-struct contracts; adding a serializer framework would increase complexity.
HideTips / UserCloak Existing small single-file plugins have no extra helper layer. Keep distinct patch callbacks even if bodies coincide: Harmony target descriptors and native argument contracts are executable metadata. UserCloak config state and account/Steam interception remain untouched.
LogisticMiner Standalone project is absent from solution, so validate it separately. VeinCacheData is already nested beside its sole owner and avoids repeated per-frame dictionaries; technology-derived caches update at explicit game/tech/vein boundaries. PRNG and mining state are authoritative, not disposable derived state. No algorithm change.
LuaScriptEngine LuaState owns interpreter/callback/timer/OBS resources independently of BepInEx hook wiring. Lua function names and returned Timer instances are dynamic API contracts; preserve them. Temporary timer-removal list avoids mutating enumeration. OBS callbacks capture connection credentials: changing reconnect/registration ownership requires a behavioral fix and acceptance test, so no speculative lifecycle rewrite is included.
OverclockEverything Public Cfg is also the serialized multiplier shape; _oldCfg holds imported values needed for migration, not a cache of current config. BeltFix contains its own native visual correction rules and multiple patches; it is not a few-line helper.
PoolOpt Keep per-pool native capacity-reset callbacks; replacing them with reflection or raw array resizing would remove mod-compatible initialization behavior. Only the duplicate managed bookkeeping is unified.
LiveStreamAssist C# Reviewed all seven API/entry C# sources, InternalsVisibleTo and project. ApiProtocol owns input/wire limits; ReflectionReader owns shallow allowlisted traversal and bounded type metadata; MainThreadDispatcher owns Unity affinity/watchdog; ApiConnection/server own concurrent transport. These are distinct responsibilities, not forwarding services. Session generation, owner token, readiness and version snapshots prevent stale asynchronous work. ProductionExtraInfoRefresh is small but contains a stateful, independently checked throttling/batch algorithm. Keep its test boundary.
LiveStreamAssist browser Reviewed all seven js/src chunks and all three maintained HTML examples. Client, GameQuery, GameText and GameIcons expose documented separate API responsibilities; text/icons remain offline. Header/footer are syntactic bundle boundaries. Positive-only product cache, _active reservation count, generation checks, allReads draining and single-flight page polling have distinct roles; do not remove them as duplicate state. Independent examples intentionally remain copyable pages; a shared polling/UI framework would add a deployment dependency.
JS/Python generation Reviewed all six Python scripts. generate_icons reuses actual extraction/discovery from generate_text; no new common module is needed. generate-text.py preserves an earlier CLI spelling. kmg.py is an independent formatting reference used by tests, not a production duplicate to route back into JS. pack_js.py is a direct ordered concatenation. Generated locale/icon maps and bundle are outputs, not separate first-party implementations; repacking produces no content diff.
Repository maintenance Read Publish-Mod.ps1, UpdateGameDlls.ps1, Directory.Build.props/targets, UpdateGameDlls project and local imports, solution, workflow and tool pinning. Keep private publish validation/token/path helpers: they isolate real security/compatibility checks and existing stub-test seams. Dotnet/PowerShell JSON evaluation, preloader compile injection and package runtime lists serve different platform boundaries. No new scanner or generic build framework is introduced.
Retired/moved modules CompressSave has documentation only and lives in another repository. LabOpt/LabOptPreloader are read-only inventory per retirement guidance, not revived or built; their details are in check-tools.

Limits

This is a repository design audit with connected-call and metadata checks, not a full correctness/security or gameplay certification. No game mechanics were rederived from stripped references. No original game method body, native patch target, injected instruction pattern or active UI geometry was changed. DSP/Unity/OBS/LAN interactive validation was not run. Existing dashboard mock failures are reproduced from the exact baseline and reported separately.