Return feature-only helpers to their owners, remove inactive scaffolding and duplicate state, and reuse existing calculation and UI work without changing public contracts or gameplay. Record repository-wide coverage, justified retentions, independent reviews and validation, including baseline dashboard fixture failures. Assisted-by: Cindy (https://cindy.app)
4.1 KiB
Independent review of small-mod cleanup
Reviewer: UXAssist audit worker, independent of the implementation author.
Baseline: 64a23e9772e7878f216cc2e281da2bc3f87d3140.
Reviewed the full diffs and connected callers/ownership for Dustbin/BeltSignal.cs, MechaDronesTweaks, HideTips, OverclockEverything and PoolOpt.
Finding corrected during review
Required imports removed with commented code. OverclockEverything still has a live MechaForge_GameTick_Transpiler that uses IEnumerable<CodeInstruction> and OpCodes. Removing System.Collections.Generic and System.Reflection.Emit would break the normal build. The implementer restored both imports in their original order. Read-back verified the correction. No unresolved finding remains in this review scope.
Behavior and boundary checks
- Dustbin: All three generic resource-loading helpers were private and used only to load the one belt-signal icon.
Dustbin.assets.icon.signal-410.pngmatches the existing assembly/root namespace and EmbeddedResource path. Signal ID, name, grid index, public IconPath, Texture2D construction, LoadImage bytes, Sprite rectangle/pivot and stream-read behavior remain the same. The loader stays in its owning BeltSignal class. No new helper file or dependency is introduced. - MechaDronesTweaks: Removed FastDronesRemover was an internal type with a single Run caller in the plugin constructor. The same plugin GUID, exact version gate (
0.0.5), external class/Start target, Harmony instance, prefix return value, catch and log behavior remain in that constructor.AccessTools.Methodresolves the new private prefix explicitly. The soft-dependency attribute keeps the same constant value. The moved helper is not an exported public type. Duplicate EnergyMultiplier binding had an identical key, value, description and range; one real binding is retained, with every other option/default unchanged. - HideTips: Removed HideMenuDemo code/configuration was wholly commented.
_patchhad no live assignment, so its OnDestroy cleanup could only observe null. Existing live Harmony setup and all presentation guards/defaults remain. No progression/statistics/event setter is bypassed by the cleanup. - OverclockEverything: Removed GalacticScale collision/transpiler experiments were comments. Export/Import save order, SaveVersion, ConfigEntry bindings/defaults and live Harmony patches remain unchanged. Required live transpiler imports are now retained.
- PoolOpt: Both old algorithms used the same reset, tail search, cursor update, recycle sort/search and shrink flow. The new occupied predicate is exactly
id == indexfor ordinary pools (including the previous null-to-zero handling) anditem != 0for trash, complementing its olditem == 0empty predicate. Index zero remains excluded by the loop. Every caller keeps its existing initial-capacity callback and capacity mutation. The removed ref capacity parameter was never read or written by either algorithm.Actionreplaces a private parameterless void delegate without changing callback timing. No public type/config/save format/native patch target changes.
PoolOpt has one intentional diagnostic normalization: the existing DEBUG reset message now also appears when an all-empty trash pool takes the tail-search reset branch. Pool, cursor, recycle, capacity and return-value behavior is unchanged. This does not justify adding a logging-mode parameter or retaining a duplicate state algorithm; the implementation report records it explicitly.
Completeness and validation
No stale FastDronesRemover/GetId/IsEmpty/SetToInitialCapacity reference or abandoned private loader chain remains in these scopes. The refactors reduce actual wrappers and duplicate implementations without replacing them with new files or speculative abstractions.
git diff --check passed for all five reviewed module groups. The implementer ran the exhaustive 16,382-case old/new PoolOpt state comparison; this reviewer additionally checked predicate mapping and every category of capacity callback in source. Parent executor owns normal Release builds and final validation logs. No in-game or third-party runtime integration was executed by this reviewer.